feat: support design tokens and paragon 23 #569

dcoa · 2025-02-18T04:12:01Z

Warning

This PR should not be merge to master directly, it should point to master-design-tokens once the branch has been created.

Description

This PR updates frontend app learner dashboard to support CSS variables and the corresponding paragon design tokens.

Changes implemented:

Replace Paragon SCSS variables with CSS variables.

Important

This PR requires a compatible version with paragon 23 of dependencies because of that the following PRs need to be merged first:

How to test

Navigate the sandbox

openedx-webhooks · 2025-02-18T04:12:06Z

Thanks for the pull request, @dcoa!

This repository is currently maintained by @2U-aperture.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
- This process (including the steps you'll need to take) is documented here.
If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

Dependencies

This PR must be merged before / after / at the same time as ...
Blockers

This PR is waiting for OEP-1234 to be accepted.
Timeline information

This PR must be merged by XX date because ...
Partner information

This is for a course on edx.org.
Supporting documentation
Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

The size and impact of the changes that it introduces
The need for product review
Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

itsjeyd · 2025-02-27T12:25:15Z

@dcoa Thank you for this contribution!

codecov · 2025-03-18T23:57:01Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.43%. Comparing base (05e9626) to head (728759d).
Report is 1 commits behind head on master-design-tokens.

Additional details and impacted files

@@                  Coverage Diff                  @@
##           master-design-tokens     #569   +/-   ##
=====================================================
  Coverage                 97.43%   97.43%           
=====================================================
  Files                       152      152           
  Lines                      1327     1327           
  Branches                    220      220           
=====================================================
  Hits                       1293     1293           
  Misses                       33       33           
  Partials                      1        1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

open-craft-grove · 2025-03-19T01:05:14Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2025-03-22T01:40:53Z

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2025-03-24T14:44:50Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2025-03-25T05:34:59Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2025-03-25T22:10:26Z

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2025-03-27T03:32:40Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2025-03-27T09:19:15Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2025-03-28T05:36:23Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2025-03-28T06:07:21Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2025-03-30T23:55:15Z

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2025-03-31T00:58:46Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2025-04-13T22:40:36Z

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2025-04-14T04:57:24Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2025-04-22T07:32:33Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2025-04-22T14:32:05Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

itsjeyd · 2025-04-24T06:56:03Z

@dcoa Just to confirm, this is unblocked now and waiting for review?

brian-smith-tcril · 2025-04-24T11:51:00Z

@itsjeyd yes this is unblocked. I have been focused on non-design-tokens work that needs to land before the Teak cut so I haven't had a chance to approve most of the MFE design tokens PRs and create the master-design-tokens branches yet.

open-craft-grove · 2025-04-28T04:15:43Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

brian-smith-tcril

🎉 This is perfect! 🎉

Thank you so much!

Once this is rebased I'll create the master-design-tokens branch, approve, and merge it!

dcoa · 2025-05-06T20:50:53Z

Rebased 😀 @brian-smith-tcril

openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 18, 2025

itsjeyd added the core contributor PR author is a Core Contributor (who may or may not have write access to this repo). label Feb 27, 2025

itsjeyd added the blocked by other work PR cannot be finished until other work is complete label Mar 14, 2025

dcoa force-pushed the dcoa/design-tokens-support branch from 420b681 to cc84281 Compare March 18, 2025 23:53

dcoa added the create-sandbox open-craft-grove should create a sandbox environment from this PR label Mar 19, 2025

dcoa force-pushed the dcoa/design-tokens-support branch from cc84281 to 4bfbb79 Compare March 22, 2025 01:02

dcoa force-pushed the dcoa/design-tokens-support branch from 8ec02ea to c4cb69c Compare March 25, 2025 04:53

dcoa requested a review from brian-smith-tcril March 25, 2025 04:54

dcoa marked this pull request as ready for review March 25, 2025 04:54

dcoa requested a review from a team as a code owner March 25, 2025 04:54

dcoa force-pushed the dcoa/design-tokens-support branch from c4cb69c to 2db6bf1 Compare March 25, 2025 21:39

dcoa force-pushed the dcoa/design-tokens-support branch from 2db6bf1 to 0c4e137 Compare March 27, 2025 08:43

dcoa force-pushed the dcoa/design-tokens-support branch from 0c4e137 to 587f5fa Compare March 28, 2025 04:51

dcoa force-pushed the dcoa/design-tokens-support branch from 0f2bb44 to ce18aa0 Compare March 30, 2025 23:21

dcoa changed the title ~~[WIP] feat: support design tokens and paragon 23~~ feat: support design tokens and paragon 23 Mar 30, 2025

dcoa changed the title ~~feat: support design tokens and paragon 23~~ [WIP] feat: support design tokens and paragon 23 Mar 30, 2025

dcoa changed the title ~~[WIP] feat: support design tokens and paragon 23~~ feat: support design tokens and paragon 23 Mar 31, 2025

itsjeyd added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. and removed blocked by other work PR cannot be finished until other work is complete labels Apr 1, 2025

MaxFrank13 moved this to Blocked in Aperture-Maintained Apr 3, 2025

dcoa force-pushed the dcoa/design-tokens-support branch from ce18aa0 to 252d4cf Compare April 13, 2025 22:04

dcoa force-pushed the dcoa/design-tokens-support branch from 252d4cf to 9600bcf Compare April 22, 2025 05:21

dcoa force-pushed the dcoa/design-tokens-support branch from 9600bcf to 04c1f65 Compare April 28, 2025 01:43

brian-smith-tcril mentioned this pull request Apr 28, 2025

Update frontend-app-learner-dashboard to use Design Tokens openedx/public-engineering#300

Closed

1 task

brian-smith-tcril reviewed May 6, 2025

View reviewed changes

dcoa force-pushed the dcoa/design-tokens-support branch from 04c1f65 to 397547d Compare May 6, 2025 20:26

dcoa added 3 commits May 7, 2025 06:40

chore: update paragon to version 23

ed5e75f

feat: update styles to css variables

4ec235c

feat: add PARAGON_THEME_URLS to env files

728759d

dcoa force-pushed the dcoa/design-tokens-support branch from 397547d to 728759d Compare May 6, 2025 20:46

brian-smith-tcril changed the base branch from master to master-design-tokens May 6, 2025 20:55

brian-smith-tcril merged commit 5340233 into openedx:master-design-tokens May 6, 2025
6 checks passed

openedx-webhooks removed the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label May 6, 2025

github-project-automation bot moved this from Blocked to Done in Aperture-Maintained May 6, 2025

github-project-automation bot moved this from Waiting on Author to Done in Contributions May 6, 2025

feat: support design tokens and paragon 23 #569

feat: support design tokens and paragon 23 #569

Uh oh!

Conversation

dcoa commented Feb 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to test

Uh oh!

openedx-webhooks commented Feb 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

itsjeyd commented Feb 27, 2025

Uh oh!

codecov bot commented Mar 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

open-craft-grove commented Mar 19, 2025

Uh oh!

open-craft-grove commented Mar 22, 2025

Uh oh!

open-craft-grove commented Mar 24, 2025

Uh oh!

open-craft-grove commented Mar 25, 2025

Uh oh!

open-craft-grove commented Mar 25, 2025

Uh oh!

open-craft-grove commented Mar 27, 2025

Uh oh!

open-craft-grove commented Mar 27, 2025

Uh oh!

open-craft-grove commented Mar 28, 2025

Uh oh!

open-craft-grove commented Mar 28, 2025

Uh oh!

open-craft-grove commented Mar 30, 2025

Uh oh!

open-craft-grove commented Mar 31, 2025

Uh oh!

open-craft-grove commented Apr 13, 2025

Uh oh!

open-craft-grove commented Apr 14, 2025

Uh oh!

open-craft-grove commented Apr 22, 2025

Uh oh!

open-craft-grove commented Apr 22, 2025

Uh oh!

itsjeyd commented Apr 24, 2025

Uh oh!

brian-smith-tcril commented Apr 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

open-craft-grove commented Apr 28, 2025

Uh oh!

brian-smith-tcril left a comment

Choose a reason for hiding this comment

Uh oh!

dcoa commented May 6, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

dcoa commented Feb 18, 2025 •

edited

Loading

openedx-webhooks commented Feb 18, 2025 •

edited

Loading

codecov bot commented Mar 18, 2025 •

edited

Loading

brian-smith-tcril commented Apr 24, 2025 •

edited

Loading